Skip to content

copilot review comments incorporation#51

Open
rajiv-jain-netapp wants to merge 5 commits intomainfrom
sync/apache-main-apr-2026
Open

copilot review comments incorporation#51
rajiv-jain-netapp wants to merge 5 commits intomainfrom
sync/apache-main-apr-2026

Conversation

@rajiv-jain-netapp
Copy link
Copy Markdown

@rajiv-jain-netapp rajiv-jain-netapp commented Apr 24, 2026

Review comments from Copilot are incorporated

Test results
All ONTAP plugin unit tests pass with a normal mvn test (including Checkstyle):
Test class
Tests
OntapVMSnapshotStrategyTest. 40
OntapPrimaryDatastoreDriverTest. 20
OntapPrimaryDatastoreProviderTest. 11
OntapPrimaryDatastoreLifecycleTest 24
UnifiedSANStrategyTest 92
UnifiedNASStrategyTest 17
StorageStrategyTest 25
Total 229

Failures: 0, errors: 0, skipped: 0.

Code coverage (current snapshot)
JaCoCo was run with prepare-agent + report on this module. Project-wide totals for cloud-plugin-storage-volume-ontap are approximately:

Instructions: 49.4% covered (6963 / 14092)
Branches: 45.0%
Lines: 49.7%
Methods: 33.3%

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants